On Sun, Apr 22, 2012 at 10:10:35AM -0700, Justin Pettit wrote:
> This is great, Ben.  Just a few minor things:
> 
> > +Out-of-band control has the following benefits:
> > +
> > +    - Simplicity: Out-of-band control slightly simplifies the switch
> > +      implementation.
> > +
> > +    - Reliability: Excessive switch traffic volume cannot interfere
> > +      with control traffic.
> 
> Do you think it's worth mentioning that we now set the DSCP bits so
> that people can prevent some of this in their "core" switches and
> routers?

I guess DSCP bits don't reassure me much.  Maybe they reduce the scope
of the problem.

> > +The following points describe important special cases of this
> > +principle.
> > +
> > +   In-band control must be implemented regardless of whether the
> > +   switch is connected.
> 
> Do you think it's worth making these bullet points to match the
> previous lists?

I kept going back and forth on that.  Since you suggested it I changed
the formatting to match the earlier bullets.

> > +Open vSwitch implements in-band control as "hidden" flows, that is,
> > +flows that are not visible through OpenFlow, and at a higher priority
> > +than wildcarded flows can be set up by through OpenFlow.  This is done
> 
> You can drop either the "by" or "through".

Done.

Thanks, I'll push this in a minute.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to