On Wed, Apr 18, 2012 at 01:26:46PM -0700, Ethan Jackson wrote: > Quite an elegant data structure. Pretty nifty.
Thanks. > On Mon, Apr 16, 2012 at 17:19, Ben Pfaff <b...@nicira.com> wrote: > > The cost of creating and initializing facets and subfacets and installing, > > tracking, and uninstalling kernel flows is significant. When most flows > > have only one or a few packets, this overhead is higher than the cost of > > handling each packet individually. This commit introduces heuristics that > > cheaply count (approximately) the number of packets seen in a flow and > > skips most of this expensive bookkeeping when the packet count exceeds a > > threshold (currently 5 packets). > > This should say "until the packet count" instead of "when the packet count". Thanks, fixed. > governer_destroy() should do nothing if passed NULL. Thanks, fixed. (I actually found this a minute ago with the unit tests. Seems I hadn't run them with the flow setup governor before. Stupid.) > The definition of init_flow_miss_execute_op() is slightly mis-indented. Thanks, fixed. > Otherwise looks good, thanks. Thank you for the review. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
