I've folded your suggestions in. They're trivial so I won't send an incremental.
Ethan On Tue, Apr 17, 2012 at 09:59, Ben Pfaff <b...@nicira.com> wrote: > On Mon, Apr 16, 2012 at 05:20:03PM -0700, Ethan Jackson wrote: >> Open vSwitch allowed users to set a custom LACP PDU transmission >> interval. This turned out to be an ill conceived idea which was >> more confusing than useful. This patch reverts Open vSwitch to the >> behavior supported in the LACP specification: two transmission >> intervals, fast and slow. >> >> Signed-off-by: Ethan Jackson <et...@nicira.com> > > slave_set_expired() still refers to custom times in a comment. > > In vswitch.xml it would be a good idea to use an "enum" constraint to > indicate that the value may be either "fast" or "slow". Then you can > drop the description of that constraint from the text. > > Otherwise this looks good. Thank you. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
