Looks good.
Ethan
On Mon, Apr 16, 2012 at 17:18, Ben Pfaff <b...@nicira.com> wrote:
> handle_flow_miss() didn't update subfacet "used" times for packets
> processed by userspace. This commit fixes the problem.
>
> Found by inspection. I didn't verify the bug in testing.
>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
> lib/dpif.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/dpif.c b/lib/dpif.c
> index febe8b0..73696e4 100644
> --- a/lib/dpif.c
> +++ b/lib/dpif.c
> @@ -678,10 +678,10 @@ void
> dpif_flow_stats_extract(const struct flow *flow, const struct ofpbuf *packet,
> struct dpif_flow_stats *stats)
> {
> - memset(stats, 0, sizeof(*stats));
> stats->tcp_flags = packet_get_tcp_flags(packet, flow);
> stats->n_bytes = packet->size;
> stats->n_packets = 1;
> + stats->used = time_msec();
> }
>
> /* Appends a human-readable representation of 'stats' to 's'. */
> --
> 1.7.9
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
