On Thu, Mar 29, 2012 at 03:00:06PM -0700, Ethan Jackson wrote: > Without this patch, using ovs-ofctl to add a rule which masks the > vlan_tci field would not work as expected unless the protocol was > explicitly set to NXM. > > Signed-off-by: Ethan Jackson <et...@nicira.com>
This is the right idea but I think that the details are wrong. If an OpenFlow 1.0 ofp_match comes in, then we should be able to convert it back to an OpenFlow 1.0 ofp_match successfully on output. However, any OpenFlow 1.0 ofp_match that matches on VLAN VID or VLAN PCP will set VLAN_CFI in vlan_tci_mask (see ofputil_wildcard_from_openflow()), whereas your proposed code will disallow outputting such a flow as OpenFlow 1.0. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
