On Wed, Mar 7, 2012 at 9:57 AM, Ben Pfaff <b...@nicira.com> wrote: > On Tue, Mar 06, 2012 at 02:37:02PM -0800, Pravin B Shelar wrote: >> Rather than using ETHTOOL_GDRVINFO to check netdev-status, use >> ovs-get-stats since it is more consistent. Covergage counter is >> added for status check. >> >> Signed-off-by: Pravin B Shelar <pshe...@nicira.com> > > In netdev_linux_get_status(), I don't understand why we want to return > vport_stats_error. We know that we have driver info at that point, so > why not just return 0? It would save a system call. > I thought netdev_get_status() call need to check status explicitly every time. If that is not the case, I will remove call to get status.
> I understand why you don't call netdev_linux_get_drvinfo() from > netdev_internal_open(), because you told me, but it's not obvious from > the code. I think that a comment is warranted. > ok. > Thanks, > > Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
