On Thu, Mar 01, 2012 at 04:30:36PM -0800, Ethan Jackson wrote:
> Version information is typically fairly useful when debugging Open
> vSwitch.  This patch adds a new version.py module which python code
> can use to report its version to callers.
> 
> Signed-off-by: Ethan Jackson <et...@nicira.com>

Good idea.

Please implement the fragment below as writes to $@.tmp followed by
"mv $@.tmp $@", otherwise an interrupted "make", or some kind of
error, can result in a partial version.py.  In theory "make" is
supposed to delete version.py in some of those cases but my experience
is that life is easier if you don't have to worry about it at all.

> +ALL_LOCAL += $(srcdir)/python/ovs/version.py
> +$(srcdir)/python/ovs/version.py: config.status
> +     $(ro_shell) > $@
> +     echo 'VERSION = "$(VERSION)"' >> $@
> +     echo 'BUILDNR = "$(BUILDNR)"' >> $@
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to