> Since the reserved field is used to get full struct flow size to be 64 bits > aligned, I believe it can be changed based on FLOW_SIG_SIZE and it doesn’t > have any other inherent meaning and since it is not used for calculating > hash I believe changing reserved size should be ok. Secondly, any other > changes I need to do or areas of code to look at to fix this problem?
We included the 'reserved' field because we prefer to have padding in structures explicit. It doesn't have any sort of semantic meaning beyond that. It's totally fine to change it to add additional fields. Adding an additional field to struct flow is a fairly involved process. You will note at the top of lib/flow.h the 'FLOW_WC_SEQ' #define. This was added to help developers find all the places that need to change when either struct flow, or the classifier changes. It's not comprehensive, but I would start by incrementing that value and seeing where the compiler leads you. Ethan > > > > Thanks > > Ravi > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
