On Thu, Feb 16, 2012 at 02:10:02PM -0800, Ethan Jackson wrote: > > Please argue out the situation with yourself and get back to me when > > you've come to a conclusion. > > After an intense bout of self directed parliamentary wrangling > (back-room deals, filibusters, ear marks, late night socratic > dialectics) I've come to the following conclusion: > > HFSC drops packets not directed to a default queue. HTB does not. > GIven this information the patch seems reasonable to me. I would > update the documentation in the patch to indicate that not all QoS > implementations actually drop traffic, but most have undesirable > behavior.
I applied this incremental: diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 8edc18e..cd50f55 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -2064,8 +2064,9 @@ actions when no specific queue has been set. Ordinarily <ref column="queues"/> should include a configuration for queue 0. When no configuration for queue 0 is present, a default configuration is used. - (Before version 1.6, Open vSwitch would drop all packets destined for - the default queue if no configuration was present.) + (Before version 1.6, Open vSwitch would leave queue 0 unconfigured in + this case. With some queuing disciplines, this dropped all packets + destined for the default queue.) </p> </column> I pushed this to master and branch-1.[2345]. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev