On Wed, Feb 15, 2012 at 03:30:49PM +0900, Simon Horman wrote:
> [handle_packet_out() in the patch.]
> ofpacts seems to be use uninitialised.
> Is it necessary to some how initialise ofpacts from
> po.actions and po.n_actions?
Oops. We can just use po.ofpacts:
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index ded3ada..6043676 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -1949,7 +1949,6 @@ handle_packet_out(struct ofconn *ofconn, const struct
ofp_packet_out *opo)
struct ofproto *p = ofconn_get_ofproto(ofconn);
struct ofputil_packet_out po;
struct ofpbuf *payload;
- struct nlattr *ofpacts;
struct flow flow;
enum ofperr error;
@@ -1979,7 +1978,7 @@ handle_packet_out(struct ofconn *ofconn, const struct
ofp_packet_out *opo)
/* Send out packet. */
flow_extract(payload, 0, 0, po.in_port, &flow);
- error = p->ofproto_class->packet_out(p, payload, &flow, ofpacts);
+ error = p->ofproto_class->packet_out(p, payload, &flow, po.ofpacts);
ofpbuf_delete(payload);
return error;
Recent changes that add some test coverage for OFPT_PACKET_OUT should
help with this.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
