On Feb 1, 2012, at 2:58 PM, Ben Pfaff wrote:
> + xvu = row.external_ids.get("xs-vif-uuid")
> + if xvu:
> + iface_id = (new_iface_ids.get(xvu)
> + or iface_ids.get(xvu)
> + or get_iface_id(row.name, xvu))
Doesn't this prefer an old iface_id (in "iface_ids") over a new one (through
get_iface_id())? Is that intended behavior? Is your concern about making a
bunch of XAPI checks to get "nicira-iface-id"?
> # When there's a vif and a tap, the tap is active (used for
> # traffic). When there's just a vif, the vif is active.
> @@ -339,6 +344,7 @@ def main():
>
> new_interfaces[row.name] = new_xvu
I don't think "new_xvu" is defined any longer, but see next comment...
> interfaces = new_interfaces
I don't think "interfaces" or "new_interfaces" are needed anymore, are they?
Thanks for tracking down this issue so quickly.
--Justin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
