On Tue, Jan 24, 2012 at 02:03:47PM -0800, Ethan Jackson wrote: > Looks good, > > In heap_raw_insert() why not use x2nrealloc() instead of xrealloc()?
Because we need heap->allocated + 1 elements instead of just heap->allocated elements. > 1) You've ifdef'd out some code. Any reason not to simply delete it? No. I just forgot to do that before committing. Removed. > 2) You've implemented print_heap() without using it. I suppose that's > for debugging purposes? Yes, this kind of thing is genuinely useful for debugging and so I'd prefer to keep it. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
