On Wed, Jan 11, 2012 at 07:25:52PM -0800, Pravin B Shelar wrote:
> Following patch implements dec_ttl as vendor action with similar
> semantics as OpenFlow 1.2. If TTL reaches zero while procession actions
> in current table, the remaining actions in previous tables are
> processed. An configuration parameter is added to make TTL decrement
> to zero generate packet in.
>
> Feature #8758
This patch adds a blank line in an unusual place in
connmgr_send_packet_in().
I think a "goto" would be in order, in place of the extra variable in
do_xlate_actions().
In ovs-ofctl.8.in, I don't think that TTL should be italic. I think
that we could be clearer with the description. Maybe like this:
.IP \fBdec_ttl\fR
Decrement TTL of IPv4 packet or hop limit of IPv6 packet. If the
TTL or hop limit is initially zero, no decrement occurs. Instead,
a ``packet-in'' message with reason code \fBOFPR_INVALID_TTL\fR is
sent to each connected controller that has enabled receiving them,
if any. Processing the current set of actions then stops.
However, if the current set of actions was reached through
``resubmit'' then remaining actions in outer levels resume
processing.
ofp-print should add support for printing
OFPC_INVALID_TTL_TO_CONTROLLER when it appears in config messages and
OFPR_INVALID_TTL when it appears in packet-in messages.
"ovs-ofctl monitor" should add the ability to request OFPR_INVALID_TTL
packet-ins and then ideally we should use that ability to test that
the packet-ins look reasonable.
Thanks,
Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
