On Wed, Jan 11, 2012 at 03:12:16PM -0800, Jesse Gross wrote:
> On kernels 2.6.37 and above IFF_OVS_DATAPATH has a unique value upstream,
> on 2.6.36 we define it to be IFF_BRIDGE_DATAPATH and below to 0.  There
> isn't really a good reason to use IFF_BRIDGE_DATAPATH on 2.6.36 (and it's
> perhaps bad because it's checked in a few places and we don't want those
> checks to trigger on just this kernel) and it makes it difficult to know
> what value we should use in the face of backporting.  Therefore, this
> just uses 0 on the places where we don't have a real value.
> 
> Reported-by: Benoit ML <ben4...@gmail.com>
> Signed-off-by: Jesse Gross <je...@nicira.com>

s/IFF_BRIDGE_DATAPATH/IFF_BRIDGE_PORT/ in the commit message above.

"git am" says:

    Applying: datapath: IFF_OVS_DATAPATH is backported by RHEL 6.2.
    /home/blp/ovs/.git/rebase-apply/patch:32: trailing whitespace.
    #if IFF_OVS_DATAPATH != 0 
    warning: 1 line adds whitespace errors.

This built OK for me with 2.6.18, 2.6.36, and 3.1.  I didn't run it.

I didn't think too hard about this, but it looks good to me.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to