On Sat, Jan 07, 2012 at 11:11:57AM -0800, Ethan Jackson wrote:
> Future patches will need the ability to skip over unsupported NXM
> headers in nx_pull_match().
>
> Signed-off-by: Ethan Jackson <[email protected]>
The change to nx_pull_match() looks incomplete to me, because I think
the added "continue;" skips these important lines at the end of the
loop:
p += 4 + length;
match_len -= 4 + length;
You could change the "while" to "for" and put those in the third clause
of the for loop.
Ideally we'd add a test case.
I think that almost every call will pass true for 'strict'. So it might
be better to keep the semantics of nx_pull_match() as-is and add a new
nx_pull_match_relaxed() or similar. (They would both be implemented as
a wrapper around an implementation that takes a bool.) But it's not a
big deal either way.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
