On Fri, Jan 06, 2012 at 03:55:47PM -0800, Gurucharan Shetty wrote:
> Currently system-type and system-version can only be set through
> ovs-vsctl and ovs-ctl in the commandline. This patch allows you
> to place system-type.conf and system-version.conf files in $etcdir
> and their contents will be used if no arguments are specified with
> ovs-vsctl or ovs-ctl.
>
> Bug #9033.
>
> Signed-off-by: Gurucharan Shetty <[email protected]>
Thanks.
Just a few minor points. First, "git am" says that you added trailing
white space, which we try to avoid:
Applying: ovs-ctl: Pull system_type and system_version from config file
/home/blp/ovs/.git/rebase-apply/patch:40: trailing whitespace.
When not provided, \fBovs-ctl\fR uses values from the optional
/home/blp/ovs/.git/rebase-apply/patch:41: trailing whitespace.
\fBsystem-type.conf\fR and \fBsystem-version.conf\fR files(see section
/home/blp/ovs/.git/rebase-apply/patch:42: trailing whitespace.
\fBFILES\fR) or it uses the \fBlsb_release\fR program, if present, to
/home/blp/ovs/.git/rebase-apply/patch:53: trailing whitespace.
The system-type and system-version values stored in the database's
/home/blp/ovs/.git/rebase-apply/patch:54: trailing whitespace.
\fBOpen_vSwitch\fR table when not specified as a command-line option.
warning: 5 lines add whitespace errors.
Second, in groff literal "-"s should be written as \-. In practice
that usually means that any - in a bold font should have \ before it.
(I see we have a couple of mistakes in this file as-is that we should
fix.)
Third, all of the option descriptions previously had little lead-in
paragraphs that explained how important it was to specify them, but
you deleted the "On systems..." lead-in paragraph for --system-type
and --system-version, which makes it harder for an integrator to
figure out whether he needs those. How about adding back a brief
lead-in paragraph, perhaps:
The following options should be specified if the defaults are not
suitable:
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
