On Fri, Jan 06, 2012 at 11:53:05AM -0800, Gurucharan Shetty wrote:
> Currently system-type and system-version can only be set through
> ovs-vsctl and ovs-ctl in the commandline. This patch allows you
> to place system-type.conf and system-version.conf files in $etcdir
> and their contents will be used if no arguments are specified with
> ovs-vsctl or ovs-ctl.
>
> Bug #9033.
>
> Signed-off-by: Gurucharan Shetty <[email protected]>
Thanks for making those changes.
What you added to ovs-ctl.8 looks good, but I'd also expect the
behavior to be mentioned earlier in the manpage, in this part:
On systems that have the lsb_release program, ovs-ctl chooses reason-
able defaults for the following options. Other systems should specify
values:
--system-type=type
--system-version=version
Sets the value to store in the system-type and system-version
columns, respectively, in the database's Open_vSwitch table.
Remote managers may use these values to determine the kind of
system to which they are connected (primarily for display to
human administrators).
There's no need to double the lines that contain just "." in the
manpage, since they just act as visual separators and have no effect.
It looks to me like ovs-ctl.in still requires the new files to be both
present or neither. I'd rather use the value from each one
independently.
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
