On Tue, Jan 03, 2012 at 02:09:42PM -0800, Ethan Jackson wrote: > handle_flow_miss() transfers ownership of its packets to > send_packet_in_miss(), but its caller deletes these packets upon > return. Future patches will remove support for un-cloned calls > altogether. Found by inspection. > > Signed-off-by: Ethan Jackson <et...@nicira.com>
I think that this changes correct code into a memory leak. The list_remove() in the LIST_FOR_EACH_SAFE loop inside handle_flow_miss() ensures that the caller will not free the packet with its ofpbuf_list_delete() call (since the packet is no longer in the list). _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
