On Mon, Dec 19, 2011 at 01:50:49PM -0800, Ansis Atteka wrote: > On Mon, Dec 19, 2011 at 1:37 PM, Ben Pfaff <b...@nicira.com> wrote: > > > On Mon, Dec 19, 2011 at 01:29:37PM -0800, Ansis Atteka wrote: > > > In current implementation vswitchd adds Controller in-band rules only if > > there is a route in > > > kernel routing table that might route traffic to the Controller. But, > > when executing > > > force-reload-kmod command, network configuration (e.g. assigned IP > > addresses, routes) are flushed > > > away, hence Controller in-band rules are not added. > > > > > > This commit fixes this limitation and allows vswitchd to add Controller > > in-band rules > > > even if there are no routes in the kernel routing table. > > > > > > Issue: #8625 > > > > > > Signed-off-by: Ansis Atteka <aatt...@nicira.com> > > > > I agree that this change makes sense. But I think that we already > > have a few instances of similar logic (grep for "tcp:") and it would > > be nice to at least centralize the logic in, say, stream.c, and > > possibly to make this logic a member function of the stream_provider. > > Ok. I will write a function that takes as input (const char* target, > tcp_default_port, ssl_default_port) and fills sockaddr_in structure as > necessary. Then this logic will be shared between controller and manager.
OK, that sounds better to me, thanks. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
