On Thu, Nov 24, 2011 at 10:18 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > Le jeudi 24 novembre 2011 à 21:20 -0800, Stephen Hemminger a écrit : > >> The problem is that there are two flow classifiers, one in OpenVswitch >> in the kernel, and the other in the user space flow manager. I think the >> issue is that the two have different code. > > We have kind of same duplication in kernel already :) > > __skb_get_rxhash() and net/sched/cls_flow.c contain roughly the same > logic... > > Maybe its time to factorize the thing, eventually use it in a third > component (Open vSwitch...)
I agree, there's no need to have three copies of packet header parsing code and that's certainly something that we would be willing to work on improving. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
