On Mon, Nov 21, 2011 at 11:14:21AM -0800, Ethan Jackson wrote: > +AT_SETUP([ofproto-dpif - output/flood flags]) > +dnl This test assumes that OpenFlow port numbers are allocated in order > +dnl starting from one.
Do we actually reliably implement that, though? I'd expect the ports to get added in a random order. Oh, I see, nothing in your test actually depends on the mapping between port name and number; it works OK as long as the ports are numbered 1 through 7 regardless of their names. Clever, great. These tests really shouldn't depend on Python since that's not a general OVS build dependency--I believe that the Python dependency here will cause "make check" to fail running in the Xen DDK. It would be better to implement whatever is necessary in Perl (which is a build dependency) or shell utilities, or as a last resort to skip them if python isn't available. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
