On Fri, Nov 18, 2011 at 11:08:08AM -0800, Jesse Gross wrote: > Both datapath and vport stats contain 64-bit members in a struct > but we write them directly in Netlink attributes which only > guarantee 32-bit alignment. This causes problems on RISC > architectures that care about alignment so this computes the stats > on the stack and then memcpy's them. > > Signed-off-by: Jesse Gross <je...@nicira.com>
I think that it only causes performance problems. The network stack doesn't worry about unaligned accesses in cases where the unaligned accesses are rare. But these unaligned accesses might not be rare, and the final code is shorter and more readable than the original code, so: Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
