On Sun, Oct 09, 2011 at 03:51:21PM -0700, Ethan Jackson wrote: > In some cases, a controller may want to take an interface down for > forwarding purposes, but avoid completely deconfiguring CFM and > thus lose all connectivity monitoring. The new 'cfm_opdown' > setting is a way to achieve this behavior.
Negative names can sometimes be confusing. For the option name, then, how about "cfm_op_state" or "cfm_opstate" or similar, with valid values "up" and "down"? I agree that it makes sense for the opdown byte in struct ccm to have this inverted sense for compatibility. Maybe it makes sense for cfm_get_opdown(), too, since then it has the same sense as cfm_get_fault(). struct cfm now has a ton of "bool" members, I wonder when it makes sense to start using a bitmask (or even bitfields)? Should we report remote_opdown in the database? I guess it would have to be true if any remote MP was down, so maybe it isn't granular enough to be useful. The code looks fine to me. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
