On Mon, Oct 3, 2011 at 10:14 AM, Ben Pfaff <[email protected]> wrote: > On Mon, Oct 03, 2011 at 10:12:37AM -0700, Justin Pettit wrote: >> On Oct 3, 2011, at 9:57 AM, Ben Pfaff wrote: >> >> > On Tue, Sep 20, 2011 at 02:42:15PM -0700, Ben Pfaff wrote: >> >> The OVS configuration database now has numerous columns that contain fixed >> >> key-value pairs. Currently there's no way to see these at a glance, >> >> because they are not presented in the summary tables just before the >> >> detailed descriptions. >> >> >> >> This commit extends the XML format so that keys within a column can be >> >> described individually, and rearranges and rewrites vswitch.xml to take >> >> advantage of this feature. >> >> --- >> >> I've put a copy of the PDF generated by these changes at: >> >> http://benpfaff.org/~blp/ovs-vswitchd.conf.db.5.pdf >> >> for proofreading. >> > >> > Would someone please review this change? It's mainly a documentation >> > change, so it's unlikely to cause implementation regressions. >> >> I thought Jesse already reviewed it. Did he only review the tunnel >> options, so you wanted a full review? I guess it wasn't clear to me >> in the original thread. > > Thanks, I didn't realize that was what was going on. > > I asked Jesse to look at the tunnel options and he gave me good > feedback on it really quickly. Jesse didn't comment on anything else > so I assumed that he just looked at the tunnel options.
Yes, I only really looked at the tunnel options. For the rest of it, the formatting changes look good but I was hoping that someone who has worked on the code more recently than me would review the content. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
