On Wed, Sep 21, 2011 at 1:08 PM, Ben Pfaff <b...@nicira.com> wrote: > On Wed, Sep 21, 2011 at 12:48:54PM -0700, Jesse Gross wrote: >> Some versions of Centos 5.6 backport the flag IFF_BRIDGE_PORT >> without the associated rx_handler changes, so this changes to >> use a version check since we really don't care about the actual >> symbol. >> >> Reported-by: Srinivasan Ramasubramanian <vrsr...@gmail.com> >> Signed-off-by: Jesse Gross <je...@nicira.com> > > The code in this function is unreadable. > > But your change looks correct. > > Acked-by: Ben Pfaff <b...@nicira.com>
Thanks, I pushed it. > ---------------------------------------------------------------------- > > Something like this might be marginally more readable: Hmm, I'm not sure that it's really that much more readable. I think the best way to make it readable is to actually separate it out into three different functions but that also results in the most code duplication. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
