Does it make sense to add ref_table to BaseType's constructor with a default value of None. Perhaps not since so little code cares about it. Curious what you think.
> def copy(self): > - return BaseType(self.type, self.enum.copy(), self.min, self.max, > - self.min_length, self.max_length, self.ref_table) > + base = BaseType(self.type, self.enum.copy(), self.min, self.max, > + self.min_length, self.max_length, > self.ref_table_name) > + base.ref_table = self.ref_table You need to return base. Looks good otherwise, Ethan _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
