On Thu, Sep 15, 2011 at 12:22 AM, Justin Pettit <[email protected]> wrote: > diff --git a/datapath/vport.c b/datapath/vport.c > index b1418a4..c0bb585 100644 > --- a/datapath/vport.c > +++ b/datapath/vport.c > @@ -301,16 +301,9 @@ int vport_set_mtu(struct vport *vport, int mtu) > if (mtu < 68) > return -EINVAL; > > - if (vport->ops->set_mtu) { > - int ret; > - > - ret = vport->ops->set_mtu(vport, mtu); > - > - if (!ret && !is_internal_vport(vport)) > - set_internal_devs_mtu(vport->dp); > - > - return ret; > - } else > + if (vport->ops->set_mtu) > + return vport->ops->set_mtu(vport, mtu); > + else > return -EOPNOTSUPP;
I think that we can actually kill off the entire vport_set_mtu() function and all of the vport implementations because there are no longer any callers. Other than that it looks good to me. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
