> I disagree with this change. If the compiler picked a signed type for > the enum (as it is allowed to do) then the comparison is useful.
Ah didn't realize that an enum could be signed. That's annoying. What if I checked if TYPE_IS_SIGNED and only did the comparison in that case? I'd rather not suppress the warning as I think it's fairly useful (caught patch 2 for example). Do you think it's worth it, or is too ugly? If I did it, I would reorder the patches so that the TYPE_IS_SIGNED patch is first. Ethan _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
