On Tue, Sep 06, 2011 at 07:32:34PM -0700, Ethan Jackson wrote: > A controller may want to know which MPIDs are reachable from an > interface configured with CFM. This patch regularly writes this > information to the database. > > Bug #7014.
In cfm_get_remote_mpids(), the string being formatted has a small fixed maximum length, so it seems wasteful to use xasprintf() instead of sprintf() or snprintf(). How can "if (n_rmps < sset_count(&rmps))" ever be true if the comment that "No more than CFM_MAX_RMPS MPIDs will be written to 'remote_mps'." on cfm_get_remote_mpids() is true? Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
