On Tue, Sep 6, 2011 at 8:04 PM, Ethan Jackson <et...@nicira.com> wrote: > Relatively minor stuff, It's pretty much there. > > Please use curly braces for one-line blocks in userspace. > ok > The comment to eth_push_vlan() needs to be updated. > ok
> I think that we should keep the eth_set_vlan_tci() function around in > addition to eth_push_vlan(). The bonding code really did want > eth_set_vlan_tci() not eth_push_vlan(). With the current version of > the patch, it's going to end up double tagging packets instead of > replacing the tag. Perhaps, eth_set_vlan_tci() could use > eth_push_vlan() in its implementation. > we discussed it offline and we concluded that set_tci is not needed as bonding code is setting vlan tag on packet just created. Thanks, Pravin. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
