Thanks for the review, I pushed this. Ethan
On Thu, Sep 1, 2011 at 00:11, Ethan Jackson <et...@nicira.com> wrote: > On Wed, Aug 31, 2011 at 23:37, Justin Pettit <jpet...@nicira.com> wrote: >> You're taking away the one bit of control that ovs-vswitchd could use at its >> own discretion? > > Haha, I actually remembered why I wrote it that way. I was planning > at some point in time to enable LACP by default in passive mode. If > we did this, we would make balance-tcp the default bonding mode which > would fall back to balance-slb if the partner switch didn't speak > LACP. Seems like this is unlikely to happen in the near term though, > and if it does we can always change the docs. > > Ethan > > >> >> Looks good. >> >> --Justin >> >> >> On Aug 31, 2011, at 3:22 PM, Ethan Jackson wrote: >> >>> Requested-by: Dan Wendlandt <d...@nicira.com> >>> --- >>> vswitchd/vswitch.xml | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml >>> index 6082256..4edc101 100644 >>> --- a/vswitchd/vswitch.xml >>> +++ b/vswitchd/vswitch.xml >>> @@ -635,8 +635,8 @@ >>> connected to. <code>active</code> ports are allowed to initiate >>> LACP >>> negotiations. <code>passive</code> ports are allowed to >>> participate >>> in LACP negotiations initiated by a remote switch, but not >>> allowed to >>> - initiate such negotiations themselves. If unset Open vSwitch will >>> - choose a reasonable default. </p> >>> + initiate such negotiations themselves. Defaults to >>> <code>off</code> >>> + if unset. </p> >>> </column> >>> >>> </group> >>> -- >>> 1.7.6 >>> >>> _______________________________________________ >>> dev mailing list >>> dev@openvswitch.org >>> http://openvswitch.org/mailman/listinfo/dev >> >> > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
