On Wed, Aug 24, 2011 at 11:59 AM, Ben Pfaff <b...@nicira.com> wrote:

> On Wed, Aug 24, 2011 at 12:28:00AM -0700, Reid Price wrote:
> > On Tue, Aug 23, 2011 at 2:05 PM, Ben Pfaff <b...@nicira.com> wrote:
> >
> > > Suggested-by: Reid Price <r...@nicira.com>
> > > ---
> > >  lib/ovsdb-types.c       |    3 +--
> > >  python/ovs/db/data.py   |    2 +-
> > >  python/ovs/db/parser.py |    4 ++--
> > >  python/ovs/db/types.py  |    8 +++-----
> > >  4 files changed, 7 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/lib/ovsdb-types.c b/lib/ovsdb-types.c
> > > index b3452dd..959f087 100644
> > > --- a/lib/ovsdb-types.c
> > > +++ b/lib/ovsdb-types.c
> > > @@ -1,4 +1,4 @@
> > > -/* Copyright (c) 2009, 2010 Nicira Networks
> > > +/* Copyright (c) 2009, 2010, 2011 Nicira Networks
> > >  *
> > >  * Licensed under the Apache License, Version 2.0 (the "License");
> > >  * you may not use this file except in compliance with the License.
> > > @@ -556,7 +556,6 @@ ovsdb_type_is_valid(const struct ovsdb_type *type)
> > >             && ovsdb_base_type_is_valid(&type->key)
> > >             && ovsdb_base_type_is_valid(&type->value)
> > >             && type->n_min <= 1
> > > -            && type->n_min <= type->n_max
> > >
> >
> > I assume this one is on purpose too
>
> Yes, I realized that if n_min <= 1 and n_max >= 1 then n_min <= n_max
> is always true.
>

Ha ha, that is a good point.  As long as those 1's never change, that should
work just fine =)
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to