On Jul 30, 2011, at 1:44 PM, Justin Pettit wrote: > On Jul 28, 2011, at 10:19 AM, Ben Pfaff wrote: > >> /* More convenience macros, for testing whether a given level is enabled in >> * THIS_MODULE. When constructing a log message is expensive, this enables it >> * to be skipped. */ >> -#define VLOG_IS_EMER_ENABLED() true >> #define VLOG_IS_ERR_ENABLED() vlog_is_enabled(THIS_MODULE, VLL_ERR) > > Do you think not having a VLOG_IS_EMER_ENABLED is useful? I guess those > shouldn't be printed in much volume. > > Otherwise, looks good to me.
You had mentioned you'd like to get this series into the 1.2.0 release. I've gone ahead and pushed this patch as is, since I want to get the changes frozen today. If you think adding VLOG_IS_EMER_ENABLED is useful, we can do it as a separate patch later. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
