On Wed, Jun 29, 2011 at 04:56:33PM -0700, Andrew Evans wrote:
> On Fri, 2011-06-24 at 15:02 -0700, Ben Pfaff wrote:
> > + case OFPUTIL_OFPAT_OUTPUT:
> > + port = ntohs(a->output.port);
> > if (port < OFPP_MAX) {
> > - ds_put_format(string, "output:%"PRIu16, port);
> > + ds_put_format(s, "output:%u", port);
>
> Is there some reason you changed this from one of the PRI.. macros to a
> format string literal, yet in other places you preserved the usage of
> the PRI.. macros?
I changed the type of 'port' from uint16_t to unsigned int at the same
time, so at least I was consistent.
Anyway, it's probably a bit clearer as uint16_t so I changed it back.
Thanks for the review.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
