Thanks for the review Reid, comments inline.
> This might be slightly more obvious as
>
> col = 'external-ids:"%s"="%s"' % (key, value)
I agree, that would be clearer. I'm just doing an indentation change
on this line though, so I'd rather leave it the same and address it
later as a wider python cleanup.
> Minor note, could do ifaces.values(), and avoid the [i], since you don't use
> it
Good idea, ill change it.
> Is it possible (and would it matter) to have a condition where
>
> vxid = {'foo': None}
> txid = {}
Nah, vxid can only hold strings so I don't think it's possible. Even
if it was possible it wouldn't matter because None is not a valid
value for any of these keys. Is there a canonically correct way to do
this in python that I should switch to? Otherwise, I'll leave it.
Ethan
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
