This code is so convoluted it's fairly difficult to understand. The get_iface_id() function is used to figure out what the iface-id should be for a given interface based on it's xs_vif_uuid. Most interfaces don't have xs_vif_uuids, and therefore won't get iface-ids. This patch gives tap devices xs_vif_uuids, and allows the get_iface_id function to figure out their iface-id so that it's caller can set it.
This patch did in fact set the iface-id properly when I tested it yesterday. On Fri, Jun 17, 2011 at 09:46, Ben Pfaff <[email protected]> wrote: > On Thu, Jun 16, 2011 at 05:15:14PM -0700, Ethan Jackson wrote: >> In some cases XenServer will give a virtual machine a tap device in >> addition to its usual vif. These tap devices need iface-ids so >> that controllers can figure out which vif they are related to. >> >> Signed-off-by: Ethan Jackson <[email protected]> > > I don't see where this patch sets iface-id. > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
