Ah ok, sounds good then. Ethan
On Tue, May 31, 2011 at 13:38, Ben Pfaff <[email protected]> wrote: > On Tue, May 31, 2011 at 01:22:02PM -0700, Ethan Jackson wrote: >> > - ? ?return true; >> > + ? ?*mr->error = ovsdb_mutation_set_execute(ovsdb_txn_row_modify(mr->txn, >> > row), >> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?mr->mutations); >> > + ? ?return *mr->error == NULL; >> >> Does '*mr->error' need to be ovsdb_error_destroy()ed before returning? >> Based on my cursory reading it does, but I don't know this code super >> well. > > No, it must not be destroyed, because ovsdb_execute_mutate() needs to > return it to its own caller for sending back to the database client. > > Thanks, > > Ben. > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
