On Fri, May 27, 2011 at 04:04:33PM -0700, Jesse Gross wrote:
> genlmsg_reply() indirectly makes a call to kmalloc but takes no
> GFP flags, instead using GFP_ATOMIC if in a softirq and GFP_KERNEL
> otherwise.  However, here we hold rcu_read_lock(), which requires
> GFP_ATOMIC but is not a softirq.  Since we've already built the
> reply message, it is safe to release rcu_read_lock(), so do that
> before calling genlmsg_reply().
> 
> Signed-off-by: Jesse Gross <[email protected]>
> CC: Hao Zheng <[email protected]>

Makes sense.

Acked-by: Ben Pfaff <[email protected]>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to