Thanks for the quick reviews, I merged this. Ethan
On Fri, Apr 1, 2011 at 1:44 PM, Ben Pfaff <[email protected]> wrote: > On Fri, Apr 01, 2011 at 01:37:10PM -0700, Ethan Jackson wrote: >> Before this (and the previous) patch, whenever cfm_configure was >> called it would set the fault_timer to expired. Thus, the next >> call to cfm_run would notice a lack of CCM reception and trigger a >> faulted status. This is a bug in and of itself, but normally would >> not be a big deal because cfm_configure should only be called >> infrequently (when the database changes). However due to an >> unrelated bug, cfm_configure() was getting called approximately once >> per second. This resulted in all monitors showing faults all of >> the time. >> >> This patch fixes the problem by not expiring the timer at >> cfm_configure(). Instead it gives it the appropriate >> fault_interval amount of time to miss heartbeats. >> >> Bug #5244. > > Looks good. Thank you! > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
