Nice catch, how did you notice this?
Incidentally, I've been thinking about if it's a good idea to
implement a timer library which may prevent errors like this in the
future.
Ethan
On Wed, Mar 30, 2011 at 1:47 PM, Ben Pfaff <b...@nicira.com> wrote:
> The lock is asserted if its expiration time has not arrived yet, not the
> reverse.
> ---
> lib/mac-learning.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/mac-learning.h b/lib/mac-learning.h
> index 16c92db..51a7ac7 100644
> --- a/lib/mac-learning.h
> +++ b/lib/mac-learning.h
> @@ -73,7 +73,7 @@ static inline void mac_entry_set_grat_arp_lock(struct
> mac_entry *mac)
> * has ever been asserted or if it has expired. */
> static inline bool mac_entry_is_grat_arp_locked(const struct mac_entry *mac)
> {
> - return time_now() >= mac->grat_arp_lock;
> + return time_now() < mac->grat_arp_lock;
> }
>
> /* MAC learning table. */
> --
> 1.7.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
