Looks Good.
On Mon, Mar 28, 2011 at 1:43 PM, Ben Pfaff <b...@nicira.com> wrote:
> When poll interval-based logging was introduced a long time, we were
> actively interested in looking at almost every long poll interval. But
> these days, with OVS working rather well, with pretty good latency, most
> of the messages are red herrings that bother some administrators and
> provoke false reports. So this commit suppresses all but the most
> egregious long poll intervals that may in fact be worth looking at.
>
> NIC-366.
> ---
> lib/timeval.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/lib/timeval.c b/lib/timeval.c
> index d24ba03..84c90f3 100644
> --- a/lib/timeval.c
> +++ b/lib/timeval.c
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2008, 2009, 2010 Nicira Networks.
> + * Copyright (c) 2008, 2009, 2010, 2011 Nicira Networks.
> *
> * Licensed under the Apache License, Version 2.0 (the "License");
> * you may not use this file except in compliance with the License.
> @@ -409,8 +409,9 @@ log_poll_interval(long long int last_wakeup, const struct
> rusage *last_rusage)
> now = time_msec();
> interval = MIN(10000, now - last_wakeup) << 4;
>
> - /* Warn if we took too much time between polls. */
> - if (n_samples > 10 && interval > mean_interval * 8) {
> + /* Warn if we took too much time between polls: at least 50 ms and at
> least
> + * 8X the mean interval. */
> + if (n_samples > 10 && interval > mean_interval * 8 && interval > 50 *
> 16) {
> struct rusage rusage;
>
> getrusage(RUSAGE_SELF, &rusage);
> --
> 1.7.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
