Only the first 6 bytes (ETH_ADDR_LEN) of the 'sys_id' argument are used,
but the prototype declared it as an array of 8 bytes. This has no effect
on the generated code--the declared size of an array parameter is
irrelevant--but it is misleading.
Also, add 'const' since the array is not modified.
---
lib/lacp.c | 2 +-
lib/lacp.h | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/lacp.c b/lib/lacp.c
index 2541623..c01a567 100644
--- a/lib/lacp.c
+++ b/lib/lacp.c
@@ -127,7 +127,7 @@ lacp_destroy(struct lacp *lacp)
* 'active' parameters. */
void
lacp_configure(struct lacp *lacp, const char *name,
- uint8_t sys_id[ETH_ADDR_LEN], uint16_t sys_priority,
+ const uint8_t sys_id[ETH_ADDR_LEN], uint16_t sys_priority,
bool active, bool fast)
{
if (!lacp->name || strcmp(name, lacp->name)) {
diff --git a/lib/lacp.h b/lib/lacp.h
index 60abadd..31ac970 100644
--- a/lib/lacp.h
+++ b/lib/lacp.h
@@ -19,6 +19,7 @@
#include <stdbool.h>
#include <stdint.h>
+#include "packets.h"
struct ds;
struct lacp;
@@ -31,7 +32,8 @@ typedef void lacp_send_pdu(void *slave, const struct lacp_pdu
*);
void lacp_init(void);
struct lacp *lacp_create(void);
void lacp_destroy(struct lacp *);
-void lacp_configure(struct lacp *, const char *name, uint8_t sys_id[8],
+void lacp_configure(struct lacp *, const char *name,
+ const uint8_t sys_id[ETH_ADDR_LEN],
uint16_t sys_priority, bool active, bool fast);
void lacp_process_pdu(struct lacp *, const void *slave,
const struct lacp_pdu *);
--
1.7.1
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
