Missed on on line 566 (add_controller), 1963
(ofconn_receives_async_msgs), 5020 (schedule_packet_in).
I'm not sure if you are going to move ofconn_receives_async_msgs out
of ofproto, in which case it wouldn't matter.
Looks Good otherwise.
Ethan
On Tue, Mar 15, 2011 at 11:36 AM, Ben Pfaff <b...@nicira.com> wrote:
> This helps to increase the level of abstraction of "struct ofconn",
> in preparation for moving it from ofproto.c into a new file.
> ---
> ofproto/ofproto.c | 18 ++++++++++++++++--
> 1 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index 17a1f71..81e89ee 100644
> --- a/ofproto/ofproto.c
> +++ b/ofproto/ofproto.c
> @@ -347,6 +347,8 @@ static void ofconn_set_rate_limit(struct ofconn *, int
> rate, int burst);
> static struct ofproto *ofconn_get_ofproto(struct ofconn *);
> static enum nx_flow_format ofconn_get_flow_format(struct ofconn *);
> static void ofconn_set_flow_format(struct ofconn *, enum nx_flow_format);
> +static int ofconn_get_miss_send_len(const struct ofconn *);
> +static void ofconn_set_miss_send_len(struct ofconn *, int miss_send_len);
>
> static void queue_tx(struct ofpbuf *msg, const struct ofconn *ofconn,
> struct rconn_packet_counter *counter);
> @@ -1906,6 +1908,18 @@ ofconn_set_flow_format(struct ofconn *ofconn, enum
> nx_flow_format flow_format)
> {
> ofconn->flow_format = flow_format;
> }
> +
> +static int
> +ofconn_get_miss_send_len(const struct ofconn *ofconn)
> +{
> + return ofconn->miss_send_len;
> +}
> +
> +static void
> +ofconn_set_miss_send_len(struct ofconn *ofconn, int miss_send_len)
> +{
> + ofconn->miss_send_len = miss_send_len;
> +}
>
> static void
> ofservice_reconfigure(struct ofservice *ofservice,
> @@ -2608,7 +2622,7 @@ handle_get_config_request(struct ofconn *ofconn, const
> struct ofp_header *oh)
> /* Send reply. */
> osc = make_openflow_xid(sizeof *osc, OFPT_GET_CONFIG_REPLY, oh->xid,
> &buf);
> osc->flags = htons(flags);
> - osc->miss_send_len = htons(ofconn->miss_send_len);
> + osc->miss_send_len = htons(ofconn_get_miss_send_len(ofconn));
> ofconn_send_reply(ofconn, buf);
>
> return 0;
> @@ -2635,7 +2649,7 @@ handle_set_config(struct ofconn *ofconn, const struct
> ofp_switch_config *osc)
> }
> }
>
> - ofconn->miss_send_len = ntohs(osc->miss_send_len);
> + ofconn_set_miss_send_len(ofconn, ntohs(osc->miss_send_len));
>
> return 0;
> }
> --
> 1.7.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
