> Will there be some users that want to use compose_lacp_packet() > without compose_lacp_pdu()? Otherwise I'd be tempted to combine the > two functions.
I don't fully understand this question. The patch which pulls LACP out of the bridge relies on them being separate so that the LACP module does not need to know the ethernet address of the interface it is sending on to generate a lacp pdu and pass to its callback. I will mention in the commit message that future patches use this functionality. > You can use ofpbuf_put(b, pdu, LACP_PDU_LEN) in place of > ofpbuf_put_zeros() followed by memcpy(). Went ahead and made this change. I can repost if you would like to see it. Otherwise I'll merge it when I've gone through the rest of the series. Ethan _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
