I noticed one more thing. After this patch, lacp_slave_enable() is reduced to just:
void lacp_slave_enable(struct lacp *lacp, void *slave_, bool enabled) { struct slave *slave = slave_lookup(lacp, slave_); if (slave->enabled != enabled) { slave->enabled = enabled; } } which in turn can be simplified to: void lacp_slave_enable(struct lacp *lacp, void *slave_, bool enabled) { struct slave *slave = slave_lookup(lacp, slave_); slave->enabled = enabled; } or even to: void lacp_slave_enable(struct lacp *lacp, void *slave_, bool enabled) { slave_lookup(lacp, slave_)->enabled = enabled; } _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev