> +#define OVSDB_BUG(MSG) \ > + ovsdb_internal_error(NULL, __FILE__, __LINE__, "%s", MSG) > +#define OVSDB_WRAP_BUG(MSG, ERROR) \ > + ovsdb_internal_error(ERROR, __FILE__, __LINE__, "%s", MSG)
I think a comment to the effect that OVSDB_WRAP_BUG takes ownership of 'ERROR' might be useful. I was surprised at that when reading the code. Your call though, it's fine either way. Looks Good. Ethan _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
