Sounds fine. On Mon, Feb 28, 2011 at 1:10 PM, Andrew Evans <aev...@nicira.com> wrote: > On 2/28/11 12:52 PM, Andrew Evans wrote: >> On 2/28/11 11:24 AM, Ethan Jackson wrote: >>> Instead of allowing vswitch-disable-in-band to take on the values >>> "true" or "false" I would prefer we allow them to take on the values >>> "0" or "1" (n > 0?). This is more consistent with other xenserver >>> other-config settings such as use_carrier, and a couple of other >>> random ones I found here: >>> http://docs.vmd.citrix.com/XenServer/5.0.0/1.0/en_gb/guest.html >> >> Actually, the only occurrance of "other_config" I see there is this: >> >> xe vif-param-set uuid=vif_uuid other_config:ethtool-tx=off > > Whoops, I should have been looking for "other-config" (with a dash). > > Empirically, true/false seems to be the convention, at least in the > networks on my XenServer 5.6.100 box: > > [root@xenserver ~]# for uuid in $(xe network-list | awk -F ': ' '/^uuid > / { print $2; }'); do xe network-param-list uuid=$uuid; done | fgrep > other-config | sort -u > other-config (MRW): automatic: false > other-config (MRW): automatic: true > other-config (MRW): is_guest_installer_network: true; ip_begin: > 192.168.128.1; ip_end: 192.168.128.254; netmask: 255.255.255.0 > > So I'm going to use "true" and "false" if that's ok with you. > > -Andrew >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev_openvswitch.org