On Fri, 12 Feb 2010 17:31:18 +0100 Christian Lippka <christian.lip...@sun.com> wrote:
> If we make the office crash in non pro than there will be never a > chance to get the qa to work on non pro again. Depends. If we make the master crash on tests in every milestone, sure. As said before an aborting assertion should only be used for corrupt internal state. If you notice a pointer to dead objects flying around or invalidated iterators that are used it is _Good_ to crash on non-pro, simply because continuing from there is pure luck (and its so much more fun to debug if dead objects have devastated the program state by a decent fandango on core). > Also, an assertion that aborts hinders my work with the office > as long as the assertion is not fixed. One abort assertion in writer > with 100 people working on the writer causes one to fix the issue and > 99 to idle until he has finished and commited the fix. If you like > your assertions to abort, you can press the cancel button. It not difficult to temporarily comment out the one assertion that went past the tests on the cws and on the master until that P1 is fixed. IIRC, Stephan said on FOSDEM that he intends to get tests to run on the master too. Assertion-free execution of those should be part of that. BR, Bjoern --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
