Hello All, one small question for Damjan:
[...] > commit 7b2bc0e6bba2fbc38d078306fe10d875115d6c86 > Author: Damjan Jovanovic > AuthorDate: Mon Jul 22 08:06:52 2024 +0200 [...] > diff --git a/main/connectivity/source/drivers/file/quotedstring.cxx > b/main/connectivity/source/drivers/file/quotedstring.cxx > index 4ea452613b..366036b6f7 100644 > --- a/main/connectivity/source/drivers/file/quotedstring.cxx > +++ b/main/connectivity/source/drivers/file/quotedstring.cxx [...] > @@ -91,49 +92,47 @@ namespace connectivity > } > > //------------------------------------------------------------------ > - void QuotedTokenizedString::GetTokenSpecial( String& _rStr,xub_StrLen& > nStartPos, sal_Unicode cTok, sal_Unicode cStrDel ) const > + void QuotedTokenizedString::GetTokenSpecial( ::rtl::OUString* > _rStr,sal_Int32& nStartPos, sal_Unicode cTok, sal_Unicode cStrDel ) const Just out of curiosity: did you change the String& _rstr parameter into a _pointer_ to ::rtl::OUString for a reason? I would have used a _reference_ (::rtl::OUString&) instead, due to the fact that you dereference that pointer and never assume it could be NULL. The only positive consequence of this change I can think of, is that code calling this method will surely not compile, and so you can easily spot where this method is used. Did I guess right? :-) Best regards, -- Arrigo --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
