Pilot-Pirx commented on code in PR #200:
URL: https://github.com/apache/openoffice/pull/200#discussion_r1466304570


##########
main/sd/source/ui/slideshow/slideshowimpl.cxx:
##########
@@ -236,6 +236,17 @@ AnimationSlideController::AnimationSlideController( 
Reference< XIndexAccess > xS
                mnSlideCount = xSlides->getCount();
 }
 
+void AnimationSlideController::setStartSlideNumber( sal_Int32 nSlideNumber )
+{
+       while( ( !maSlideVisible[nSlideNumber] ) 
+                       || ( nSlideNumber > maSlideVisible.size() ) ) 
nSlideNumber++;
+
+       if(nSlideNumber > maSlideVisible.size())
+               mnStartSlideNumber = 0;

Review Comment:
   If this PR was never tested, then you should convert it to a "draft".
   This way it cannot be merged accidentally and we can continue to work on it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Reply via email to